Re: [PATCH] expand mutt vars as we do environment vars
On Thursday, 12 January 2006 at 19:06, Phil Pennock wrote:
> Theoretically allows an arbitrary number of my_vars without risking
> buffer overflow of Matches by moving it to a dynamic array; does mutt
> get tested with memory-leak detectors, since this one static pointer
> will hold memory not freed before process exit.
I put in a half-hearted attempt to satisfy valgrind some time ago, but
it's mostly a waste of time - might as well let the OS reclaim the
memory instead of going through the FREE overhead...
On Friday, 13 January 2006 at 14:23, Phil Pennock wrote:
> On 2006-01-13 at 13:43 +0100, Michael Tatge wrote:
> > thank you for the patch. It only does half the job though.
> > I can tab complete my own variable names but it does not expand the
> > values.
>
> Oops, sorry, didn't know that was possible so didn't look into the
> function below it. Too fixated on making sure that I didn't introduce
> overflow problems with Matches. Thanks, neat feature. :^)
I've applied this patch. Thanks again.
> Try this instead (and if people let me know if they prefer the patches
> on a web-server or as a MIME attachment, I'm happy to change).
I like MIME better, personally.