<<< Date Index >>>     <<< Thread Index >>>

Re: [RFC] [PATCH] seperate coloring of index fields



* René Clerc <rene@xxxxxxxx> [24-02-2005 00:58]:

> * Christian Aichinger <Greek0@xxxxxxx> [24-02-2005 00:34]:
> 
> > I've written a patch for mutt that allows different fields of the
> > index display to be colored separately. The patch can be seen in
> > action at <URL:http://greek0.net/~greek0/mutt/mutt-indexcolor.png>.
> > 
> > I'd appreciate comments, since this is my first patch for mutt and
> > I'm not really sure that my implementation is the best way to do it.
> > Please note that this patch isn't ready for inclusion (though it
> > works fine).
> 
> My first comment, after a quick compile and configuration:
> 
> This rocks.
> 
> Second:  the way the configuration should be done is a bit obscure,
> because the "color" directives that you now need to use for this
> feature to take effect, do not indicate whatsoever that it has effect
> on the index.  Perhaps a better way would be to do it in the same
> manner as the "color header" directives, with the regexp replaced by
> the six possible entities that can be colored.

Third comment:  there are bugs.

- take a look at the attribution line in this e-mail - not sure how it
  will end up on the list, but here in Vim it contains:

    * René Clerc <rene@xxxxxxxx> [^N^V24-02-2005 00:58^N^Q]:
    
  (attribution="* %n <%a> [%(%d-%m-%Y %H:%M)]:?")

- the status line in the index is mangled too.  An example:

-^N^U S>^N^Q- ^N^T1173^N^Q/1194: René Clerc             ^N^SRe: [RFC] [PATCH] 
seperate coloring of index field
 -- (93%)

  (set status_format="-%r-Mutt: %f [Msgs:%?M?%M/?%m%?n? New:%n?%?o? Old:%o?%?d? 
Del:%d?%?F? Flag:%F?%?t? Tag:%t?%?p? Post:%p?%?b? Inc:%b?%?l? 
%l?]---(%s/%S)-%>-(%P)-%[[%H:%M %d/%m/%y]]--")

  Sorry for the long lines.  By the way, the %[[%H:%M %d/%m/%y]] is from
  Byrial Jensens status_time patch, but I will not advocate that now (at
  least, not in this thread)..

All this found during testing with a CVS mutt, on Debian/testing.

If you need help in debugging or testing, I'm glad to offer it..

-- 
René Clerc                      - (rene@xxxxxxxx) - PGP: 0x9ACE0AC7

CAT, n.  A soft, indestructible automaton provided by nature to be
kicked when things go wrong in the domestic circle.
-Ambrose Bierce, "The Devil's Dictionary"

Attachment: pgpUu1qx8vG4J.pgp
Description: PGP signature