<<< Date Index >>>     <<< Thread Index >>>

Re: [RFC] [PATCH] seperate coloring of index fields



On Thu, Feb 24, 2005 at 05:26:27PM +0100, René Clerc wrote:
> Third comment:  there are bugs.
> 
> - take a look at the attribution line in this e-mail - not sure how it
>   will end up on the list, but here in Vim it contains:
> 
>     * René Clerc <rene@xxxxxxxx> [^N^V24-02-2005 00:58^N^Q]:
[.. more examples of the same problem]

Thanks for your report, I knew where the problem is when I saw it.
Actually I guessed that something like this would happen when
writing the patch, but somehow I forgot about this then.

The cause is that the color markers were embedded in the format
strings, no matter if the result was intended for the index or for
some other part of mutt.

Luckily the same problem was happening sometime in the past, with
the thread tree that's drawn as part of the subject line in index.
So in the flags parameter passed to hdr_format_str there's already a
bit that indicates whether the result is intended for the index or
for something else.

Long story short: 
The fix was trivial, a new patch is available at:
<URL:http://greek0.net/~greek0/mutt/mutt-indexcolor2.diff>

Thanks for testing and commenting my patch.

Cheers,
Greek0