Re: [BUG] failure if passphrase had to be reentered
On Wed, Jan 26, 2005 at 08:21:07PM +0100, Christoph Ludwig wrote:
> 3) Wait longer than smime_timeout seconds.
>
> 4) Compose a 3rd mail, make mutt sign it and press 'y'
> --> a) Mutt asks again for the passphrase.
> b) Openssl is called to sign the mail.
> *** Openssl fails and complains about an incorrect passphrase! ***
>
> 5) Press 'Ctrl-f' ("forget passphrase") and retry to send the mail
> --> a) Mutt asks again for the passphrase.
> b) The mail is signed via openssl.
> c) The mail is sent.
Although I don't know the reason, I suspect this line:
===================================================================
--- smime.c 30 Oct 2004 20:45:34 -0000 3.35
+++ smime.c 27 Jan 2005 03:03:19 -0000
@@ -102,6 +102,7 @@
/* Use cached copy. */
return 1;
+ memset (SmimePass, 0, sizeof (SmimePass));
if (mutt_get_password (_("Enter SMIME passphrase:"), SmimePass, sizeof
(SmimePass)) == 0)
{
SmimeExptime = time (NULL) + SmimeTimeout;
===================================================================
This is the same as the 20040623 change in pgp.c.
===================================================================
--- pgp.c 17 Jun 2004 20:36:13 -0000 3.27
+++ pgp.c 23 Jun 2004 08:09:43 -0000 3.28
@@ -74,6 +74,8 @@
if (now < PgpExptime)
/* Use cached copy. */
return 1;
+
+ pgp_void_passphrase ();
if (mutt_get_password (_("Enter PGP passphrase:"), PgpPass, sizeof
(PgpPass)) == 0)
{
===================================================================
--
tamo