Re: Security issue / bad UI design in mutt CVS (encryption options)

[Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>]

On 2004-08-08 14:30:46 +0200, Adeodato Simó wrote:

> >      if(!SmimeDefaultKey)
> > -   mutt_message("Can\'t sign: No key specified. use sign(as).");
> > +   mutt_message("Can\'t sign: No key specified. Use Sign As.");
> 
>   any reason not to _() the message?

Sloppiness.  Fixed.  (Besides, escaping the single quote is nonsense.)

>   and, perhaps:
> 
> > +  snprintf (prompt, sizeof (prompt), 
> > +       _("PGP (e)ncrypt, (s)ign, sign (a)s, (b)oth, %s, or (c)lear? "),
> > +       (msg->security & INLINE) ? _("PGP/M(i)ME") : _("(i)nline"));

>   will translators surely understand (from the po file) that the
>   translation of PGP/M(i)ME and (i)nline has to keep the same key as
>   shortcut?

Since they also have to translate the shortcut string, that should
better be the case.

-- 
Thomas Roessler · Personal soap box at <http://log.does-not-exist.org/>.