Re: Security issue / bad UI design in mutt CVS (encryption options)

[Adeodato Simó <asp16@xxxxxxxxx>]

* Thomas Roessler [Sun, 08 Aug 2004 13:15:34 +0200]:

> Here's a proposed patch that I'd consider reasonable:

  thanks for looking into it!

> * This makes the S/MIME and PGP menus consistent.
> * "sign" and "encrypt" now mean "sign only" and "encrypt only."
> * "forget it" is now called "clear", and has (c) as a new shortcut.
>   (f) continues to be accepted, but isn't documented in the menu.
> * Bailing out of the prompt of "sign as" does not clear a
>   previously-set "sign" flag.
> * The PGP menu says "(i)nline" or "PGP/M(i)ME", depending on context.

  quite reasonable all.

> Comments before I commit this?

  just a tiny thing:

>      if(!SmimeDefaultKey)
> -     mutt_message("Can\'t sign: No key specified. use sign(as).");
> +     mutt_message("Can\'t sign: No key specified. Use Sign As.");

  any reason not to _() the message?

  and, perhaps:

> +  snprintf (prompt, sizeof (prompt), 
> +         _("PGP (e)ncrypt, (s)ign, sign (a)s, (b)oth, %s, or (c)lear? "),
> +         (msg->security & INLINE) ? _("PGP/M(i)ME") : _("(i)nline"));

  will translators surely understand (from the po file) that the
  translation of PGP/M(i)ME and (i)nline has to keep the same key as
  shortcut?

  thanks again,


  P.S.: btw, bg.po was not updated on Apr 12 as all other po files.

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
 
And don't get me wrong - I don't mind getting proven wrong. I change my
opinions the way some people change underwear. And I think that's ok.
                -- Linus Torvalds