Re: [PATCH] incorporating inline into pgp menu
On Tue, Apr 13, 2004 at 02:12:25AM -0400, Dale Woolridge wrote:
> On 13-Apr-2004 00:05 David Shaw wrote:
> |
> | and 'ask-no'). However, the action for the 'no' value does nothing
> | when the mail is sent and silently dumps the user back into the
> | compose menu.
> |
> | I think an error message here would be useful to tell the user that
> | the message cannot be sent, and why.
>
> You're right of course. In your patch, I see you've used:
>
> mutt_error("Message can't be sent using inline PGP.");
>
> Since there's a prompt already, perhaps it's sufficient to use the
> already translated (and generic) "Mail not sent." and as a message
> instead of an error since it's (supposed to be?) expected behaviour
> for those who play with the setting:
>
> mutt_message _("Mail not sent.");
It doesn't really say why the mail isn't being sent. The mail could
be unsendable for a different reason, and this would hide that from
the user. Since the default is to prompt the user for a PGP/MIME
upgrade, though, it's probably okay.
David