On 13-Apr-2004 00:05 David Shaw wrote:
|
| and 'ask-no'). However, the action for the 'no' value does nothing
| when the mail is sent and silently dumps the user back into the
| compose menu.
|
| I think an error message here would be useful to tell the user that
| the message cannot be sent, and why.
You're right of course. In your patch, I see you've used:
mutt_error("Message can't be sent using inline PGP.");
Since there's a prompt already, perhaps it's sufficient to use the
already translated (and generic) "Mail not sent." and as a message
instead of an error since it's (supposed to be?) expected behaviour
for those who play with the setting:
mutt_message _("Mail not sent.");
| Also, the name $pgp_mime_ask is not clear, especially for a
| quadoption. The answer to the question "should I ask about using
| PGP/MIME" cannot be "No, but ask" ;) How about $pgp_mime_auto ?
Yes, a much more apt name for the variable.
| Patch for these two items attached, plus a change to default
| $pgp_mime_auto to "ask-yes" rather than "no" as I suspect that is a
| more common case (inline doesn't work, the obvious next thing to do is
| to try PGP/MIME).
Indeed, "no" was definitely a bad choice for the default. I may have
intended "yes" really (to match existing mutt behaviour), but "ask-yes"
seems the best choice.
regards.
--
-dale
Attachment:
pgpb3cOgAG37d.pgp
Description: PGP signature