bug#1791: marked as done (mutt-1.4.1i: mutt leaks an fd each time it opens a pgp signed mail item)
Your message dated Sun, 8 Feb 2004 12:45:39 +0100
with message-id <20040208114539.GW30329@xxxxxxxxxxxxxxxxxxxxxxxxxx>
and subject line bug#1791: mutt-1.4.1i: mutt leaks an fd each time it opens a
pgp signed mail item
has caused the attached bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Herr der Kaefer
(administrator, GUUG bugs database)
--------------------------------------
Received: (at submit) by bugs.guug.de; 3 Feb 2004 18:29:36 +0000
>From dsl@xxxxxxxxx Tue Feb 03 19:29:35 2004
Received: from host213-122-8-236.in-addr.btopenworld.com ([213.122.8.236])
by trithemius.gnupg.org with esmtp (Exim 3.35 #1 (Debian))
id 1Ao5Ig-00067W-00
for <submit@xxxxxxxxxxxx>; Tue, 03 Feb 2004 19:29:34 +0100
Received: from snowdrop.l8s.co.uk (localhost [IPv6:::1])
by snowdrop.l8s.co.uk (8.12.9/8.12.8) with ESMTP id i12M9BkS013558;
Mon, 2 Feb 2004 22:09:11 GMT
Received: (from dsl@localhost)
by snowdrop.l8s.co.uk (8.12.9/8.12.9) id i12M9AUB021740;
Mon, 2 Feb 2004 22:09:10 GMT
Date: Mon, 2 Feb 2004 22:09:10 GMT
From: David Laight <dsl@xxxxxxxxx>
Message-Id: <200402022209.i12M9AUB021740@xxxxxxxxxxxxxxxxxx>
Subject: mutt-1.4.1i: mutt leaks an fd each time it opens a pgp signed mail item
To: submit@xxxxxxxxxxxx
X-Spam-Status: No, hits=1.2 required=4.0
tests=UPPERCASE_25_50
version=2.55
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
Package: mutt
Version: 1.4.1i
Severity: normal
-- Please type your report below this line
Mutt leaks an fd every time it processes a pgp signed mail item.
The patch below fixes it (patch-ak in netbsd's pkgsrc).
David
--- pgp.c.orig 2002-01-09 15:39:28.000000000 +0000
+++ pgp.c 2004-02-01 13:37:49.000000000 +0000
@@ -737,14 +737,14 @@
if (pgp_copy_checksig (pgperr, s->fpout) >= 0)
badsig = 0;
-
- safe_fclose (&pgperr);
if ((rv = mutt_wait_filter (thepid)))
badsig = -1;
dprint (1, (debugfile, "pgp_verify_one: mutt_wait_filter returned %d.\n",
+rv));
}
+
+ safe_fclose (&pgperr);
state_attach_puts (_("[-- End of PGP output --]\n\n"), s);
-- Mutt Version Information
Mutt 1.4.1i (2003-03-19)
Copyright (C) 1996-2002 Michael R. Elkins and others.
Mutt comes with ABSOLUTELY NO WARRANTY; for details type `mutt -vv'.
Mutt is free software, and you are welcome to redistribute it
under certain conditions; type `mutt -vv' for details.
System: NetBSD 1.6W (i386)
Compile options:
-DOMAIN
-DEBUG
-HOMESPOOL -USE_SETGID +USE_DOTLOCK -DL_STANDALONE
+USE_FCNTL -USE_FLOCK
+USE_POP +USE_IMAP -USE_GSS +USE_SSL -USE_SASL
+HAVE_REGCOMP -USE_GNU_REGEX
+HAVE_COLOR +HAVE_START_COLOR -HAVE_TYPEAHEAD +HAVE_BKGDSET
+HAVE_CURS_SET +HAVE_META +HAVE_RESIZETERM
+HAVE_PGP -BUFFY_SIZE -EXACT_ADDRESS -SUN_ATTACHMENT
+ENABLE_NLS -LOCALES_HACK +HAVE_WC_FUNCS +HAVE_LANGINFO_CODESET
+HAVE_LANGINFO_YESEXPR
+HAVE_ICONV -ICONV_NONTRANS +HAVE_GETSID +HAVE_GETADDRINFO
ISPELL="/usr/pkg/bin/ispell"
SENDMAIL="/usr/sbin/sendmail"
MAILPATH="/var/mail"
PKGDATADIR="/usr/pkg/share/mutt"
SYSCONFDIR="/usr/pkg/etc"
EXECSHELL="/bin/ksh"
-MIXMASTER
To contact the developers, please mail to <mutt-dev@xxxxxxxx>.
To report a bug, please use the flea(1) utility.
---------------------------------------
Received: (at 1791-done) by bugs.guug.de; 8 Feb 2004 11:43:10 +0000
>From roessler+bounce@xxxxxxxxxxxxxxxxxx Sun Feb 08 12:43:06 2004
Received: from does-not-exist.info ([217.160.221.198]
helo=kamino.does-not-exist.org)
by trithemius.gnupg.org with esmtp (Exim 3.35 #1 (Debian))
id 1ApnL8-0007H7-00
for <1791-done@xxxxxxxxxxxx>; Sun, 08 Feb 2004 12:43:06 +0100
Received: from voyager.does-not-exist.org (unknown [195.46.244.47])
(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
(No client certificate requested)
by kamino.does-not-exist.org (Postfix) with ESMTP
id 6B47C3141A3; Sun, 8 Feb 2004 12:45:51 +0100 (CET)
Received: by voyager.does-not-exist.org (Postfix, from userid 500)
id 7145980C2; Sun, 8 Feb 2004 12:45:39 +0100 (CET)
Date: Sun, 8 Feb 2004 12:45:39 +0100
From: Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>
To: David Laight <dsl@xxxxxxxxx>, 1791-done@xxxxxxxxxxxx
Subject: Re: bug#1791: mutt-1.4.1i: mutt leaks an fd each time it opens a pgp
signed mail item
Message-ID: <20040208114539.GW30329@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <200402022209.i12M9AUB021740@xxxxxxxxxxxxxxxxxx>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200402022209.i12M9AUB021740@xxxxxxxxxxxxxxxxxx>
User-Agent: Mutt/1.5.6i
X-Spam-Status: No, hits=-106.6 required=4.0
tests=AWL,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,
REFERENCES,REPLY_WITH_QUOTES,UPPERCASE_25_50,
USER_AGENT_MUTT,USER_IN_WHITELIST
autolearn=ham version=2.55
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
Thanks. This problem has fixed quite some time ago in the unstable
branch.
--
Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>
On 2004-02-02 22:09:10 +0000, David Laight wrote:
> From: David Laight <dsl@xxxxxxxxx>
> To: submit@xxxxxxxxxxxx
> Date: Mon, 2 Feb 2004 22:09:10 GMT
> Subject: bug#1791: mutt-1.4.1i: mutt leaks an fd each time it opens a pgp
> signed mail item
> Reply-To: David Laight <dsl@xxxxxxxxx>, 1791@xxxxxxxxxxxx
> X-Spam-Level: **
>
> Package: mutt
> Version: 1.4.1i
> Severity: normal
>
> -- Please type your report below this line
>
> Mutt leaks an fd every time it processes a pgp signed mail item.
> The patch below fixes it (patch-ak in netbsd's pkgsrc).
>
> David
>
>
> --- pgp.c.orig 2002-01-09 15:39:28.000000000 +0000
>
> +++ pgp.c 2004-02-01 13:37:49.000000000 +0000
>
> @@ -737,14 +737,14 @@
>
>
>
> if (pgp_copy_checksig (pgperr, s->fpout) >= 0)
>
> badsig = 0;
>
> -
>
> - safe_fclose (&pgperr);
>
>
>
> if ((rv = mutt_wait_filter (thepid)))
>
> badsig = -1;
>
>
>
> dprint (1, (debugfile, "pgp_verify_one: mutt_wait_filter returned
> %d.\n",
> +rv));
>
> }
>
> +
>
> + safe_fclose (&pgperr);
>
>
>
> state_attach_puts (_("[-- End of PGP output --]\n\n"), s);
>
>
>
> -- Mutt Version Information
>
> Mutt 1.4.1i (2003-03-19)
> Copyright (C) 1996-2002 Michael R. Elkins and others.
> Mutt comes with ABSOLUTELY NO WARRANTY; for details type `mutt -vv'.
> Mutt is free software, and you are welcome to redistribute it
> under certain conditions; type `mutt -vv' for details.
>
> System: NetBSD 1.6W (i386)
> Compile options:
> -DOMAIN
> -DEBUG
> -HOMESPOOL -USE_SETGID +USE_DOTLOCK -DL_STANDALONE
> +USE_FCNTL -USE_FLOCK
> +USE_POP +USE_IMAP -USE_GSS +USE_SSL -USE_SASL
> +HAVE_REGCOMP -USE_GNU_REGEX
> +HAVE_COLOR +HAVE_START_COLOR -HAVE_TYPEAHEAD +HAVE_BKGDSET
> +HAVE_CURS_SET +HAVE_META +HAVE_RESIZETERM
> +HAVE_PGP -BUFFY_SIZE -EXACT_ADDRESS -SUN_ATTACHMENT
> +ENABLE_NLS -LOCALES_HACK +HAVE_WC_FUNCS +HAVE_LANGINFO_CODESET
> +HAVE_LANGINFO_YESEXPR
> +HAVE_ICONV -ICONV_NONTRANS +HAVE_GETSID +HAVE_GETADDRINFO
> ISPELL="/usr/pkg/bin/ispell"
> SENDMAIL="/usr/sbin/sendmail"
> MAILPATH="/var/mail"
> PKGDATADIR="/usr/pkg/share/mutt"
> SYSCONFDIR="/usr/pkg/etc"
> EXECSHELL="/bin/ksh"
> -MIXMASTER
> To contact the developers, please mail to <mutt-dev@xxxxxxxx>.
> To report a bug, please use the flea(1) utility.
>
>
>