Re: PGP menu
On Mon, Apr 12, 2010 at 01:27:42PM +0200, Vincent Lefevre wrote:
In pgp_send_menu() from pgp.c, one has:
case 5: /* (f)orget it */
case 6: /* (c)lear */
msg->security = 0;
break;
Shouldn't (f)orget be removed as it isn't displayed?
This may confuse the user if he types on "f" by mistake.
I noticed that as well and wasn't sure why it was there. I'm all for removing
the 'f' key since it is not in the prompt.
Moreover
PGP (e)ncrypt, (s)ign, sign (a)s, (b)oth, %s, or (c)lear?
has recently been changed to:
PGP (e)ncrypt, (s)ign, sign (a)s, (b)oth, toggle %s, or (c)lear?
The new form is less clear. For instance, one had:
PGP: Encrypt (PGP/MIME)
and it was proposed:
PGP (e)ncrypt, (s)ign, sign (a)s, (b)oth, (i)nline, or (c)lear?
So, 'i' would set to inline. Now one gets:
PGP (e)ncrypt, (s)ign, sign (a)s, (b)oth, toggle (i)nline, or (c)lear?
but toggle is done between two states, and this doesn't appear
clearly. "toggle format" might be better.
The reason for the change was that the original prompt was unclear to a user.
This user thought that 'i' would do an inline signature. Thus I was trying to
make it more clear what that key did.
Would this be better?
PGP (e)ncrypt, (s)ign, sign (a)s, (b)oth, use %s format, or (c)lear?
Thus:
PGP (e)ncrypt, (s)ign, sign (a)s, (b)oth, use (i)nline format, or (c)lear?
PGP (e)ncrypt, (s)ign, sign (a)s, (b)oth, use PGP/M(i)ME format, or (c)lear?
me