Re: [patch] sorting efficiency
On 2008-09-10 12:53:41 -0700, Brendan Cully wrote:
> This reads fine to me. I'm not sure I'm crazy about the
> SHORT_STRING change in compare_* though - it'd be nicer if we
> could just do fewer comparisons. I grant that we use fixed-length
> buffers all over the place. Some day maybe we should think about
> keeping a buffer pool around :)
I guess part of the reasoning is that if the first 128 characters of
an e-mail address are identical, nobody will be able to see the
difference on screen anyway. ;-)
> Do you have any idea how much time the alloc/free stuff in compare_foo
> is burning?
Nope, didn't do measurements on that part. It did seem (from
looking at gprof outputs) like that code is run a hell of a lot of
times, though.
--
Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>