<<< Date Index >>>     <<< Thread Index >>>

Re: What happened to strict_mime?



On 2007-03-22 10:12:08 +0100, Thomas Roessler wrote:

> > +  s = strdup (AssumedCharset);
> > +  /* If it begins with ":", make it empty */
> > +  if (s != strtok (s, ":"))
> > +    *s = '\0';
> > +  return s;

This code is actually rather wrong by itself.

> Combined with this:
> 
> > +    char *assumed_charset = mutt_get_default_charset ();
> > +    if ((charset || *assumed_charset) && Charset)
> > +      cd = mutt_iconv_open (Charset, charset ? charset : assumed_charset, 
> > M_ICONV_HOOK_FROM);
> > +    FREE (&assumed_charset);
> >    }
> 
> ... leads to heap coruption.

It doesn't -- I had read the other code a bit differently.  Sorry.

-- 
Thomas Roessler   <roessler@xxxxxxxxxxxxxxxxxx>