Re: mutt: Improve const correctness
On Tuesday, 02 August 2005 at 23:07, Brendan Cully wrote:
> On Tuesday, 02 August 2005 at 21:21, Bob Bell wrote:
> > On Tue, Aug 02, 2005 at 02:59:25PM -0700, Brendan Cully wrote:
> > >2. Looks like you've got some of your consts backwards? eg:
> > > int mutt_account_fromurl (ACCOUNT* account, ciss_url_t const* url)
> >
> > I can't see the patch because it gives me an error, so I don't know for
> > sure which way you are coming down on this. I noticed that the wiki
> > page referenced uses the form "foo_t const *foo". I personally,
> > however, am much more familiar with and prefer the form "const foo_t
> > *foo". This is the format I'm used to seeing in man pages and the like.
>
> Sorry, I turned off the tracker. Probably should have waited a
> bit... anyway, I also really prefer const foo_t*. It's consistent with
> the rest of mutt, and it doesn't make me have to stop and think
> whenever I see it. Not having to stop and think can't be underrated.
er, overrated? I don't think I haven't been reading too much of the
menu_move_off name thread.