Re: For 1.5.9: menu_move_off (was: Change in behavior <current-middle>)
On Saturday, March 19, 2005 at 9:53:36 PM +0900, Tamotsu Takahashi wrote:
> On Sat, 19 Mar 2005, Alain Bench wrote:
>>| annoying interaction with page jumps near top of index
> Please try this (attached) patch, named menu.diff.1.
Thank you! It fixes exact example, but introduces new problems.
One example:
· With $menu_context=7 on a 34 lines menu, anywhere, say you see lines
#150 to #183. Now do a <next-page><previous-page>, you should see
150-183 again. But you see 143-176.
> And menu.diff.2 should fix <next-page>. i.e.
> <last-entry><previous-page><next-page> should give you the last entry.
Applying both patches seems to fix above bullet. But still:
· Do a <first-entry><next-page> and move cursor down 20 times with
<next-entry> until you scroll 1 line. Do a <previous-page>, you should
see 2-35. But you see 14-47.
· Do a <first-entry><next-page><next-page>: You see 62-95. Do a
<first-entry><next-page><next-entry><next-page>: You should also see
62-95. But you see 63-96.
The destination of <next-page> and <previous-page> is dependent on
initial cursor position, when it clearly should not. It should only
depend on initial page position. Same for <half-down> and <half-up>.
Bye! Alain.
--
« if you believe the /*code comments*/, I've got a //bridge to sell you. »