Re: [PATCH] generic spam detection
On Wed, Jul 14, 2004 at 08:23:21PM -0500, David Champion wrote:
> Useful, indeed. In case it's not apparent, you can do this by setting
> $spam_separator to "". The override behavior is only when it's
> completely unset.
Thank you. I didn't know that... ;)
So, documentation on the difference between unset and ""
would be helpful. (Perhaps already documented?)
> I think that "" should not be the default, but I'm split evenly on
> whether it should be unset or "," (or the like).
Either will do. But I slightly prefer "," as the default.
Maybe makedoc.c doesn't make difference between unset and "" in
the place of default values. You can avoid this problem with any
non-null default.
> > spam-hook, ham-hook?
...
> more consistent. But it's not clear to me whether it would be more
> connsistent, particularly. I wonder what others think of this.
At least I'm satisfied by your patch. V3 has "nospam *" ability!
It doesn't matter to me whether it is a command or a hook.
Well, it will be more useful if spam-hook accepts "~b" as well as
the default "~h" pattern. But, then spam-hook ignores $default_hook
and introduces new inconsistency. And perhaps it costs too much. :)
No more comments from me. And I don't object to CVS inclusion at all.
Thanks for your work against spam.
--
tamo