Re: [PATCH] generic spam detection
On Mon, Jul 12, 2004 at 02:03:23AM -0500, David Champion wrote:
> Feedback: I've still not heard from anyone using this patch. If you are,
> please let us know how it's working out.
Just now, I am trying your patch.
I think it is a very great enhancement. (%1-substitution, in particular.)
It is not only for spam, but also for extremely flexible index_formatting.
We can (ab)use this feature to show the summary of a message's header
information, for example.
Problem:
I am using hcache.18 patch. Your spam detection ignores cached messages.
i.e. This doesn't work with hcache patch at all.
Solutions:
1. A variable to always scan headers (even if they are already cached).
(hormel side)
2. If one or two of the patches (hcache.19 and hormel.2) are included
into CVS, this problem will be fixed soon (by sithglan or dgc, hehehe).
(upstream side; The best solution!!!)
3. Use "#if USE_HCACHE" to avoid conflict. (I'm gonna try to do this.)
(hormel side)
4. Adjust hcache patch. (hcache side)
BTW, I suggest you set a default value of $spam_separator.
Maybe ", " or "/".
With a default value, all we have to do is execute "spam" command
as many times as we need. Very simple usage. Good for beginners.
One more suggestion; Redraw display more often.
Your patch defines spam_separator with "R_NONE."
I guess "R_INDEX" is better. (I haven't tested yet.)
Lastly, I want "unspam" and "unnospam" to remove spam definitions.
I often misspell regexps and I have to remove such entries from list.
Thanks,
--
tamo