<<< Date Index >>>     <<< Thread Index >>>

Re: [patch] add "notalternates" functionality



On Wed, May 26, 2004 at 12:23:10PM EDT, Charles Cazabon wrote:

> A week ago, I asked on mutt-users about an apparent problem I was having with
> the alternates/unalternates functionality.  It turned out mutt didn't actually
> support what I thought unalternates was supposed to do.  In a nutshell, I
> needed a command to tell mutt "addresses matching the following regex are
> /not/ me, despite them matching a regex in the alternates list".
> 
> Original thread is here:
> http://marc.theaimsgroup.com/?t=108482073000007&r=1&w=2
> 
> I've added this functionality, as "notalternates" (and unnotalternates, though
> I haven't needed that).  I've tried to keep true to the style of the existing
> code and documentation.

You took a rather straightforward approach, but as we noted in the other
thread, if we want to provide the same facilities for, say subscribe,
we'll need to add an analog to your code separately for each statement
we want to "enable" in this way.  IMHO, a more general solution would
be to simply change the regex syntax to accomodate "in" and "out" parts.
That way, anything that uses regex lists in Mutt would automatically gain
support for this automatically without introducing any new statements.

> diff -ur mutt-build/init.c mutt.notalternates/init.c
> --- mutt-build/init.c Wed Feb 11 02:20:25 2004
> +++ mutt.notalternates/init.c Wed May 26 09:20:31 2004

> @@ -1096,9 +1096,9 @@
>        {
>       int not = 0;
>  
> -     /* $alternates is case-insensitive,
> +     /* $alternates and notalternates are case-insensitive,

You may wanna change that a tad for consistency:
+       /* $alternates and $notalternates are case-insensitive,

(I know, it's just a nitpick.)

Thanks for the patch, either way,
 - Dave

-- 
Uncle Cosmo, why do they call this a word processor?
It's simple, Skyler.  You've seen what food processors do to food, right?

Please visit this link:
http://rotter.net/israel

Attachment: pgpXAOLWIHD8Y.pgp
Description: PGP signature