Re: [PATCH] remove bogus FREE

[Rocco Rutte <pdmef@xxxxxxx>]

Hi,

* Aron Griffis wrote:
> # HG changeset patch
> # User Aron Griffis <agriffis@xxxxxxxxx>
> # Date 1245455779 14400
> # Branch HEAD
> # Node ID ee3d174297bb38fd461253f5f8d340c31a7db4c8
> # Parent  9ae13dedb5ede4d0bfbbd65e21a200bae23b4e3b
> remove bogus FREE
> 
> It's impossible for cur->personal to be non-NULL at this point,
> since cur was calloc'd just a couple lines prior.
> 
> Signed-off-by: Aron Griffis <agriffis@xxxxxxxxx>
> 
> diff --git a/rfc822.c b/rfc822.c
> --- a/rfc822.c
> +++ b/rfc822.c
> @@ -451,8 +451,6 @@
>        cur = rfc822_new_address ();
>        if (phraselen)
>        {
> -     if (cur->personal)
> -       FREE (&cur->personal);
>       /* if we get something like "Michael R. Elkins" remove the quotes */
>       rfc822_dequote_comment (phrase);
>       cur->personal = safe_strdup (phrase);

Pushed as 5923:ee3d174297bb, thanks!

Rocco