Re: [Mutt] #2139: messages with base64-encoded CRLF pgp bits can't be read
#2139: messages with base64-encoded CRLF pgp bits can't be read
------------------------------+---------------------------------------------
Reporter: asp16@xxxxxxxxx | Owner: mutt-dev
Type: defect | Status: closed
Priority: minor | Milestone:
Component: mutt | Version: 1.5.11
Resolution: fixed | Keywords:
------------------------------+---------------------------------------------
Changes (by pdmef):
* status: new => closed
* resolution: => fixed
Old description:
> {{{
> On Debian's Bug#340116 (http://bugs.debian.org/340116), Daniel Stone
> reports that messages that are partially PGP-encrypted can no longer be
> read by mutt, which fails with "Could not copy message".
>
> From what I understand, this is fixed with Brendan's following commit
> (since I can't reproduce with current CVS):
>
> 2005-10-10 18:26:31 Brendan Cully <brendan@xxxxxxxxxx> (brendan)
>
> * pgp.c: Make PGP decode failure non-fatal when displaying
> messages (as opposed to decode-saving them). I think it would
> be
> nicer to include the original text when decryption fails
> though...
>
> However, I myself was still experiencing the problem for some messages.
> After a bit of investigation, I found out that Mutt was failing for
> base64-encoded messages. For example, this one, created by Mutt itself:
>
> http://people.debian.org/~adeodato/tmp/2005-11-21/base64.mbox
>
> On further investigation, I saw that it only failed if the result of
> base64-decoding the text contained CRLF. If one takes the above message,
> and recodes the base64 chunk to not contain CRLF, it can be opened
> without problems:
>
> http://people.debian.org/~adeodato/tmp/2005-11-21/base64-nocrlf.mbox
>
> Also, and with respect Daniel's original report, note that even if mutt
> properly opens the message, it outputs somehow confusing messages.
> First:
>
> Could not decrypt PGP message
>
> And then, when displaying:
>
> PGP message successfully decrypted.
>
> Sample message:
>
> http://people.debian.org/~adeodato/tmp/2005-11-21/encrypted.mbox
> >How-To-Repeat:
> >Fix:
> Unknown
> }}}
New description:
{{{
On Debian's Bug#340116 (http://bugs.debian.org/340116), Daniel Stone
reports that messages that are partially PGP-encrypted can no longer be
read by mutt, which fails with "Could not copy message".
From what I understand, this is fixed with Brendan's following commit
(since I can't reproduce with current CVS):
2005-10-10 18:26:31 Brendan Cully <brendan@xxxxxxxxxx> (brendan)
* pgp.c: Make PGP decode failure non-fatal when displaying
messages (as opposed to decode-saving them). I think it would
be
nicer to include the original text when decryption fails
though...
However, I myself was still experiencing the problem for some messages.
After a bit of investigation, I found out that Mutt was failing for
base64-encoded messages. For example, this one, created by Mutt itself:
http://people.debian.org/~adeodato/tmp/2005-11-21/base64.mbox
On further investigation, I saw that it only failed if the result of
base64-decoding the text contained CRLF. If one takes the above message,
and recodes the base64 chunk to not contain CRLF, it can be opened
without problems:
http://people.debian.org/~adeodato/tmp/2005-11-21/base64-nocrlf.mbox
Also, and with respect Daniel's original report, note that even if mutt
properly opens the message, it outputs somehow confusing messages.
First:
Could not decrypt PGP message
And then, when displaying:
PGP message successfully decrypted.
Sample message:
http://people.debian.org/~adeodato/tmp/2005-11-21/encrypted.mbox
>How-To-Repeat:
>Fix:
Unknown
}}}
--
Comment:
All supplied mboxes work without problems with latest tip. The content of
forsaker.mbox is actually inline PGP wrapped in HTML labeled as
application/pgp. This is so horribly broken that we can't do anything
about I'm afraid.
--
Ticket URL: <http://dev.mutt.org/trac/ticket/2139#comment:7>
Mutt <http://www.mutt.org/>
The Mutt mail user agent