Re: [PATCH] Sort the 'Incoming' buffy list
* Rocco Rutte (pdmef@xxxxxxx) wrote:
> The patch is not quite correct, I'd say. First, sort_browser can
> change. What if it changed after the list got sorted already? Second,
> sorting is mutt_find_mailbox() is wrong as that's part of the
> $check_mbox_size option (which must be set, and even then works for
> mbox/mmdf only).
>
> The way to "correctly" implement sort_browser for the sidebar IMHO is to
> maintain a second list for it. Hooking into the parse routine
> mutt_parse_mailboxes() and parse_set() you get told about new mailboxes
> and sort_browser changes.
The sorting does happen in mutt_parse_mailboxes() instead of
mutt_find_mailbox(), apparently diff got confused while figuring out the
corresponding function. I hadn't noticed that before. I'll also have a
look at parse_set().
> For vanilla mutt I think sorting Incoming doesn't make sense as the list
> is only presented through sort_browser only (except maybe for buffy
> cycling).
I wasn't sure whether it's useful for vanilla mutt either, so if you say
it's better to use it only with the sidebar i'll send it to the sidebar
maintainer. Maybe then we can use a sidebar-specific option to make it a
bit more obvious.
Jan
--
OpenPGP Key-ID: CF1635D4
"Those who dream by day are cognizant of many things which escape those who
dream only by night." -- Edgar Allan Poe