Re: Timeouts?

[Rocco Rutte <pdmef@xxxxxxx>]

Hi,

* Rocco Rutte wrote:
> Hi,
>
> * Brendan Cully wrote:
> > On Wednesday, 03 September 2008 at 12:47, Kyle Wheeler wrote:
>
> > > I'm assuming some change in either [12a6de725483] or [4f67fc336986], but I
> > > haven't figured out what exactly did it yet.
>
> > It'd be great if you could bisect.
>
> For me, bisecting says the former is bad.

Looking at it, this is just an idea. I have:

  $imap_keepalive = 300
  $timeout = 60
  $mail_check = 120

[4f67fc336986] removes the imap_keepalive() call from the pager's main
loop and calls it everytime in km_dokey(). The change in [12a6de725483]
however only calls imap_keepalive() if $imap_keepalive < $timeout. Maybe
we need something like this handling the $imap_keepalive >= $timeout
case:

  i = Timeout > 0 ? Timeout : 60;
#if USE_IMAP
  if (!ImapKeepalive)
    ;
  else if (ImapKeepalive >= i)
    imap_keepalive()
  else
    while (ImapKeepalive < i)
    {
      ...
    }
#endif

instead?

Regards, Rocco