Re: [Mutt] #2866: Bug#362919: update broke ~h in reply-hooks
#2866: Bug#362919: update broke ~h in reply-hooks
Changes (by me):
* status: new => closed
* resolution: => fixed
Old description:
> {{{
>
> There was a regression while fixing mutt/2190:
> mutt/2190: mutt segfaults when replying from the view-attachments menu
>
> (Dato posted this on mutt-dev in February, resubmitting to gnats now.)
>
> ----- Forwarded message from Marco d'Itri <md@xxxxxxxx> -----
>
> Date: Sun, 16 Apr 2006 15:39:07 +0200
> From: Marco d'Itri <md@xxxxxxxx>
> Reply-To: Marco d'Itri <md@xxxxxxxx>, 362919@xxxxxxxxxxxxxxx
> To: Debian Bug Tracking System <submit@xxxxxxxxxxxxxxx>
> Subject: Bug#362919: update broke ~h in reply-hooks
>
> Package: mutt
> Version: 1.5.11+cvs20060403-1
> Severity: normal
>
> After upgrading to this mutt version, this part of my configuration
> stopped working and is now reported as an error at startup:
>
> reply-hook "~h '^X-Enigmail-Supports: .*pgp-mime'" set pgp_autosign
> reply-hook "~h '^User-Agent: Mutt/'" set pgp_autosign
> reply-hook "~h '^X-Mailer: (Evolution|The Bat|Sylpheed)'" set
> pgp_autosig=
> n
>
> --=20
> ciao,
> Marco
>
> ----- End forwarded message -----
> ----- Forwarded message from Adeodato Sim=F3 <dato@xxxxxxxxxxxxxx> -----
>
> Date: Sun, 16 Apr 2006 18:09:46 +0200
> From: Adeodato Sim=F3 <dato@xxxxxxxxxxxxxx>
> To: Marco d'Itri <md@xxxxxxxx>, 362919@xxxxxxxxxxxxxxx
> Cc: mutt-dev@xxxxxxxx
> Subject: Re: Bug#362919: update broke ~h in reply-hooks
>
> * Marco d'Itri [Sun, 16 Apr 2006 15:39:07 +0200]:
>
> > Package: mutt
> > Version: 1.5.11+cvs20060403-1
> > Severity: normal
>
> > After upgrading to this mutt version, this part of my configuration
> > stopped working and is now reported as an error at startup:
>
> > reply-hook "~h '^X-Enigmail-Supports: .*pgp-mime'" set pgp_autosign
> > reply-hook "~h '^User-Agent: Mutt/'" set pgp_autosign
> > reply-hook "~h '^X-Mailer: (Evolution|The Bat|Sylpheed)'" set
> pgp_autos=
> ign
> =20
> That'd be upstream answers to your #352357:
>
> 2006-03-03 10:12:27 Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>
> =
> (roessler)
>
> * hook.c: reply-hook is used in contexts where we don't have
> a Context structure available. Hence, it must not require the
> full message.
>
> If you read the bug log, you'll see that there's a chance Thomas will
> fix it the way you want if you ask nicely.
>
> Cheers,
>
> --=20
> Adeodato Sim=F3 dato at
> net.com.org.e=
> s
> Debian Developer adeodato at debian.org
> =20
> Guy on cell: You can't fist someone for that long. They turn into a
> handpuppet after 5 minutes.
> -- http://www.overheardinnewyork.com/archives/002602.html
>
> ----- End forwarded message -----
>
> Christoph
> --=20
> cb@xxxxxxxx | http://www.df7cb.de/
>
> >Fix:
>
> Unknown
> }}}
New description:
{{{
There was a regression while fixing mutt/2190:
mutt/2190: mutt segfaults when replying from the view-attachments menu
(Dato posted this on mutt-dev in February, resubmitting to gnats now.)
----- Forwarded message from Marco d'Itri <md@xxxxxxxx> -----
Date: Sun, 16 Apr 2006 15:39:07 +0200
From: Marco d'Itri <md@xxxxxxxx>
Reply-To: Marco d'Itri <md@xxxxxxxx>, 362919@xxxxxxxxxxxxxxx
To: Debian Bug Tracking System <submit@xxxxxxxxxxxxxxx>
Subject: Bug#362919: update broke ~h in reply-hooks
Package: mutt
Version: 1.5.11+cvs20060403-1
Severity: normal
After upgrading to this mutt version, this part of my configuration
stopped working and is now reported as an error at startup:
reply-hook "~h '^X-Enigmail-Supports: .*pgp-mime'" set pgp_autosign
reply-hook "~h '^User-Agent: Mutt/'" set pgp_autosign
reply-hook "~h '^X-Mailer: (Evolution|The Bat|Sylpheed)'" set pgp_autosig=
n
--=20
ciao,
Marco
----- End forwarded message -----
----- Forwarded message from Adeodato Sim=F3 <dato@xxxxxxxxxxxxxx> -----
Date: Sun, 16 Apr 2006 18:09:46 +0200
From: Adeodato Sim=F3 <dato@xxxxxxxxxxxxxx>
To: Marco d'Itri <md@xxxxxxxx>, 362919@xxxxxxxxxxxxxxx
Cc: mutt-dev@xxxxxxxx
Subject: Re: Bug#362919: update broke ~h in reply-hooks
* Marco d'Itri [Sun, 16 Apr 2006 15:39:07 +0200]:
> Package: mutt
> Version: 1.5.11+cvs20060403-1
> Severity: normal
> After upgrading to this mutt version, this part of my configuration
> stopped working and is now reported as an error at startup:
> reply-hook "~h '^X-Enigmail-Supports: .*pgp-mime'" set pgp_autosign
> reply-hook "~h '^User-Agent: Mutt/'" set pgp_autosign
> reply-hook "~h '^X-Mailer: (Evolution|The Bat|Sylpheed)'" set pgp_autos=
ign
=20
That'd be upstream answers to your #352357:
2006-03-03 10:12:27 Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx> =
(roessler)
* hook.c: reply-hook is used in contexts where we don't have
a Context structure available. Hence, it must not require the
full message.
If you read the bug log, you'll see that there's a chance Thomas will
fix it the way you want if you ask nicely.
Cheers,
--=20
Adeodato Sim=F3 dato at net.com.org.e=
s
Debian Developer adeodato at debian.org
=20
Guy on cell: You can't fist someone for that long. They turn into a
handpuppet after 5 minutes.
-- http://www.overheardinnewyork.com/archives/002602.html
----- End forwarded message -----
Christoph
--=20
cb@xxxxxxxx | http://www.df7cb.de/
>Fix:
Unknown
}}}
Comment:
[c310dd3d6d73] fixes the original bug for #2190 while not disabling reply-
hook's use of ~h when replying to a message from the index menu. The hook
containing "~h" will just return false when it is used in sitatuions where
"ctx" is NULL (ie, from the attachment menu).
--
Ticket URL: <http://dev.mutt.org/trac/ticket/2866#comment:1>