<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] Compilation warnings, configure



On Saturday, 07 April 2007 at 14:23, Fabian Groffen wrote:
> On 03-04-2007 14:48:13 -0700, Brendan Cully wrote:
> > > There is a  type-pun warning in hcache.c:300 left, but I've had
> > > my ride for now :)
> > > 
> > > So far for the no-more-warnings-in-mutt evening.  Sorry for the spam
> > > everyone!
> > 
> > I had already applied about half of your changes. Can you rediff?
> 
> Well, no, so I redid the changes and ran a diff again.  I used the
> 1.5.15 released tarball.  See patch attached.  I also fixed the
> remaining type-pun I referred to above.  It seems to work fine here.
> 
> Please carefully note the CHAR_MAX_LENGTH thing.  You accidentially
> checked in my first "fix" there, which is in any case wrong.  I now did
> some other hack around it.  In any case, make sure that this (unsigned
> char) cast that now is in the code disappears.

I've applied these (with a simpler patch for
CHAR_MAX_LENGTH). Thanks.

Attachment: pgp7QFizO1EAP.pgp
Description: PGP signature