<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] Use execvp to call sendmail



* Fri Mar 16 2007 Derek Martin <invalid@xxxxxxxxxxxxxx>
> On Fri, Mar 16, 2007 at 04:18:45PM +0100, Christoph Berg wrote:
> > > I'm curious: does the ssh client binary tend to move around the
> > > filesystem randomly on these peoples' systems?
> > 
> > No, but mutt just says "exec error" which is in no way enlightening on
> > what is actually going wrong. 
> 
> So you "fix" the lack of information by opening up a security hole?
> How about just making Mutt emit a more useful error message instead?

Or write the caution in the manual explicitly. It's much easier.
(It takes more than three lines to examine the path in sendlib.c. ;)


--- a/init.h    Fri Mar 16 17:14:54 2007 +0900
+++ b/init.h    Sat Mar 17 12:20:13 2007 +0900
@@ -2514,7 +2514,7 @@ struct option_t MuttVars[] = {
   ** .pp
   ** Specifies the program and arguments used to deliver mail sent by Mutt.
   ** Mutt expects that the specified program interprets additional
-  ** arguments as recipient addresses.
+  ** arguments as recipient addresses. Note: You need to specify the absolute 
pathname.
   */
   { "sendmail_wait",   DT_NUM,  R_NONE, UL &SendmailWait, 0 },
   /*

-- 
tamo