<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] Add $umask for mailboxes and attachments



On Friday, 16 March 2007 at 13:15, Christoph Berg wrote:
> Hi, and sorry for the late followup.
> 
> Imho there are 3 issues left in the umask handling:
> 
> #1: main.c sets umask(077) unconditionally. Should be removed.
> 
> #2: Even after fixing #1, the original process umask is not respected
> when creating files. One could argue that there should be a way to
> tell mutt "don't mess with my umask", e.g. by setting umask=0.
> 
> #3: The current implementation sets/resets the umask all the time. The
> advantage is that subshells created should still have the parent umask
> (after item #1 is fixed), but the places where umask calls are done
> are scattered all over the code and look overly complex.

The reason for the current implementation is that I think tempfiles
(which mutt generates all the time) should remain 077. I only wanted
$umask to affect things the user creates explicitly (mailboxes and
saved attachments).

Attachment: pgpiMJOhS2AHp.pgp
Description: PGP signature