<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] new fmtpipe updates



On Wednesday, 14 March 2007 at 01:33, David Champion wrote:
> * On 2007.03.13, in <20070313210222.GB24389@xxxxxxxxxxxxxxxxx>,
> *     "Brendan Cully" <brendan@xxxxxxxxxx> wrote:
> > 
> > On further reflection, I think your fmtpipe.3 patch should work well
> > enough -- people will just have to get used to putting their string in
> > extra quoting. But the one you submitted seems to have some garbage in
> > it ('/tmp/ass', and an #if 0 block), and doesn't really quote things
> > properly for shell (embedded single quotes would break it). Can you
> > clean these things up, and maybe add the \| check?
> 
> These are fixed in fmtpipe.4, attached.

I've pushed this version, thanks!

> I've also added a mutt_xtitle program in mutt_xtitle.c, with hooks into
> Makefile.am.  It's sufficient for a common case of setting xterm titles,
> e.g.:
> 
>   set pager_format="mutt_xtitle '%-.20n: %.40s' '-%Z- %C/%m: %-20.20n   %s' |"
> 
> That should help make the xterm titlebar use case more out-of-box.
> But if it's not important, feel free to ignore the Makefile.am and
> mutt_xtitle.c hunks in the diff.

I dropped it only because it was in C. I've added a shell equivalent
in contrib, which I think is a bit friendlier for users to hack on.

Care to update the documentation?

Attachment: pgpx6fG7OW6tx.pgp
Description: PGP signature