<<< Date Index >>>     <<< Thread Index >>>

Re: mutt_adv_mktemp() ?



On Wed, Oct 04, 2006 at 10:28:09PM +0200, Thomas Roessler wrote:
> So, overall, I don't think the change is worth it.  If done
> properly, it's nothing I'd oppose, though.  

When I mentioned this with other vendors, Solar Designer replied that
he has already addressed this issue with the version of mutt shipped
with Owl:

On Thu, Oct 05, 2006 at 01:58:18AM +0400, Solar Designer wrote:
> FWIW, we have Mutt's temporary file handling reworked in Owl:
> 
>       http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/mutt/
>
> The patch is mutt-1.4.2.1-owl-tmp.diff - unfortunately, it's 46 KB
> large.
>
> IIRC, upstream didn't understand the problem at the time (early 2003)
> and we did not push hard enough.
> 
> I just did some searching and found this:
>                                          
>         http://marc.theaimsgroup.com/?l=mutt-dev&m=101662241815461
> 
> (it was early 2002, actually, but we only got Mutt into Owl a year
> later).
> 
> Apparently, the primary reason the patch was not accepted is that we
> were dropping the creation of temporary files with particular suffixes
> in favor of plain mkstemp(3).  I'm not sure what Mutt needs those
> suffixes for.  Anyway, our current patch _does_ have the suffixes logic,
> so maybe we should have simply resubmitted (in 2003?)

While 1.4.2.1 may be a little old to directly apply today :) portions
of it may save someone some time from reinventing wheels.

Attachment: pgpVyAmY55RQj.pgp
Description: PGP signature