<<< Date Index >>>     <<< Thread Index >>>

Re: doc build failure



* Jukka Salmi wrote on Thu, Sep 14, 2006 at 03:11:22AM CEST:
> Moritz Barsnick --> mutt-dev (2006-09-14 02:53:53 +0200):
> > Are you sure that this is what your ksh is choking on?
> 
> Yes. But in the meantime I noticed that this is probably a problem
> specific to the NetBSD PD KSH, thus it should be fixed there...

Yes, it's a known pdksh bug.

Please apply the following workaround to mutt, thank you.  (The right
hand side of a variable assignment will not be word-split after command
substitution, so there is no need for double-quotes there.)

Cheers,
Ralf

        * doc/Makefile.am: Work around pdksh "`\"...\"`" quoting
        issue with reldate.h.

Index: doc/Makefile.am
===================================================================
RCS file: /cvsroots/mutt/doc/Makefile.am,v
retrieving revision 3.1
diff -u -r3.1 Makefile.am
--- doc/Makefile.am     18 Jul 2006 18:04:15 -0000      3.1
+++ doc/Makefile.am     14 Sep 2006 02:03:58 -0000
@@ -132,7 +132,8 @@
 stamp-doc-xml: $(top_srcdir)/makedoc.c $(top_srcdir)/init.h manual.xml.head 
manual.xml.tail \
                $(top_srcdir)/VERSION ../reldate.h
        $(MAKE) ../makedoc$(EXEEXT)
-       ( sed -e "s/@VERSION\@/`cat $(top_srcdir)/VERSION` (`cut -d\\\" -f2 
../reldate.h`)/" $(srcdir)/manual.xml.head ;\
+       ( date=`cut -d\" -f2 ../reldate.h`; \
+         sed -e "s/@VERSION\@/`cat $(top_srcdir)/VERSION` ($$date)/" 
$(srcdir)/manual.xml.head ;\
          $(MAKEDOC_CPP) $(top_srcdir)/init.h | ../makedoc -s ) |      \
                cat - $(srcdir)/manual.xml.tail > manual.xml
        touch stamp-doc-xml