<<< Date Index >>>     <<< Thread Index >>>

doc build failure



Hi,

while building Mutt from CVS HEAD on a current NetBSD system I noticed
the following problem:

$ cd /usr/local/src/mutt
$ ./prepare --prefix=/usr/local [...]
[...]
gmake[4]: Entering directory `/src/local/mutt/doc'
gmake[4]: `../makedoc' is up to date.
gmake[4]: Leaving directory `/src/local/mutt/doc'
( sed -e "s/@VERSION\@/`cat ../VERSION` (`cut -d\\\" -f2 ../reldate.h`)/" 
./manual.xml.head ;\
          gcc -E [...] -D_MAKEDOC -C ../init.h | ../makedoc -s ) |      \
                cat - ./manual.xml.tail > manual.xml
/bin/ksh: no closing quote
touch stamp-doc-xml
xsltproc --nonet -o manual.html ./html.xsl manual.xml
manual.xml:1: parser error : StartTag: invalid element name
</sect1>
 ^
manual.xml:1: parser error : Extra content at the end of the document
</sect1>
 ^
unable to parse manual.xml
gmake[3]: [manual.html] Error 6 (ignored)
[...]


This is PD KSH shipped with NetBSD. While the Mutt makefile is correct
and this problem is PD KSH's fault, I'd suggest the attached patch to
fix the problem. Any chance to get this committed?


Cheers, Jukka

-- 
bashian roulette:
$ ((RANDOM%6)) || rm -rf ~
Index: doc/Makefile.am
===================================================================
RCS file: /cvsroots/mutt/doc/Makefile.am,v
retrieving revision 3.1
diff -u -p -r3.1 Makefile.am
--- doc/Makefile.am     18 Jul 2006 18:04:15 -0000      3.1
+++ doc/Makefile.am     13 Sep 2006 20:40:07 -0000
@@ -132,7 +132,7 @@ mutt.1: $(srcdir)/mutt.man
 stamp-doc-xml: $(top_srcdir)/makedoc.c $(top_srcdir)/init.h manual.xml.head 
manual.xml.tail \
                $(top_srcdir)/VERSION ../reldate.h
        $(MAKE) ../makedoc$(EXEEXT)
-       ( sed -e "s/@VERSION\@/`cat $(top_srcdir)/VERSION` (`cut -d\\\" -f2 
../reldate.h`)/" $(srcdir)/manual.xml.head ;\
+       ( sed -e "s/@VERSION\@/$$(cat $(top_srcdir)/VERSION) ($$(cut -d\" -f2 
../reldate.h))/" $(srcdir)/manual.xml.head ;\
          $(MAKEDOC_CPP) $(top_srcdir)/init.h | ../makedoc -s ) |      \
                cat - $(srcdir)/manual.xml.tail > manual.xml
        touch stamp-doc-xml