Re: mutt/2355: Mutt can't be built with a separate build dir and read-only source dir
The following reply was made to PR mutt/2355; it has been noted by GNATS.
From: Brendan Cully <brendan@xxxxxxxxxx>
To: bug-any@xxxxxxxxxxxxx
Cc:
Subject: Re: mutt/2355: Mutt can't be built with a separate build dir and
read-only source dir
Date: Fri, 4 Aug 2006 16:58:42 -0700
On Tuesday, 18 July 2006 at 15:15, Rocco Rutte wrote:
> > +++ po/Makefile.in.in 17 Jul 2006 18:33:04 -0000
> > @@ -12,6 +12,7 @@ VERSION = @VERSION@
> > # These two variables depend on the location of this directory.
> > subdir = po
> > top_builddir = ..
> > +builddir = $(top_builddir)/$(subdir)
> >
> > SHELL = /bin/sh
> > @SET_MAKE@
> > @@ -68,7 +69,7 @@ CATALOGS = @CATALOGS@
> > $(MSGFMT) -o $@ $<
> >
> > .po.gmo:
> > - file=$(srcdir)/`echo $* | sed 's,.*/,,'`.gmo \
> > + file=$(builddir)/`echo $* | sed 's,.*/,,'`.gmo \
> > && rm -f $$file && $(GMSGFMT) --statistics -o $$file $<
> >
> > This part looks odd. Why do you need $(builddir)? Isn't that always
> > going to amount to . ?
>
> Not to me. If builddir==srcdir, then yes. $(GMSGFMT) will get an -o flag
> for the destination file generated within $(top_srcdir)/po which won't
> do if srcdir is read-only. $(builddir) is only to make it more readable
> and used as a variable to prevent errors should the 'po' directory ever
> get a different name.
the part that confuses me is
+builddir = $(top_builddir)/$(subdir)
isn't that the same as
+builddir = .
?
> The build with read-only source dir (and without included gettext) works
> fine here with this patch but breaks in po/ already without it.
alright, I'll apply this or a variant.