Hi, * Matthias Andree [06-07-18 00:40:03 +0200] wrote:
- m4/Makefile.am.in is not needed (a next step might switch prepare over to autoreconf once the po/Makefile.in.in hacks are gone). Replaced it by a real m4/Makefile.am to avoid special treatment.
A part of this patch is bad: it adds this to po/Makefile.in.in: chmod u+w $(srcdir)For mutt/2355 it may be a partial solution, but I suggest reverting this bit. First, the user may not be allowed to change permissions. Second, if builddir is not the same as source dir (which mutt claims to support), changing permissions is not necessary at all.
My choice would be to fix the Makefiles instead to cleanly work for builddir!=sourcedir. For mutt/2355 I posted a patch properly using the builddir inside po/ to generate the gmo files, Brendan complained about this bit and I explained why I think it's okay. But I didn't get any feedback so far; maybe others could look at it?
bye, Rocco -- :wq!