<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] More valgrind memory leaks



On Saturday, 08 July 2006 at 04:25, Kyle Wheeler wrote:
> The ones I got in my valgrind (all I did was launch mutt, log into my 
> IMAP account, and exit):
> 
>    13 bytes in 1 blocks are definitely lost in loss record 24 of 279
>       at 0x401B422: malloc (vg_replace_malloc.c:149)
>       by 0x80C2020: safe_malloc (lib.c:146)
>       by 0x80C21BB: safe_strdup (lib.c:217)
>       by 0x80EA600: imap_parse_path (util.c:116)
>       by 0x80E3CD0: imap_open_mailbox (imap.c:601)
>       by 0x80928BC: mx_open_mailbox (mx.c:698)
>       by 0x8087389: main (main.c:963)
> 
> This one is simple to fix - it's a throwaway variable. The attached 
> patch (mutt.postleak.patch) should fix it.

This first one's in, thanks! I just modified it to null out pmx.mbox
before the path parser. In your patch, if Postponed wasn't a valid
IMAP path, mutt would attempt to free whatever happened to be in
pmx.mbox (probably random stack contents).

Attachment: pgpoaT1WgYye9.pgp
Description: PGP signature