Re: mutt/2139: messages with base64-encoded CRLF pgp bits can't be read

[Adeodato Simó <dato@xxxxxxxxxxxxxx>]

* Thomas Roessler [Tue, 22 Nov 2005 13:25:01 +0100]:

Hi again,

>  And there I went into my own trap (which is, indeed, still another
>  reason why application/pgp and other non-MIME-related PGP
>  integrations are bad).

>  Here's the correct patch:

>  diff -u -r3.23 handler.c
>  --- handler.c        21 Oct 2005 04:35:37 -0000      3.23
>  +++ handler.c        22 Nov 2005 12:20:46 -0000
>  @@ -1754,16 +1754,16 @@
>     switch (b->encoding)
>     {
>       case ENCQUOTEDPRINTABLE:
>  -      mutt_decode_quoted (s, b->length, istext, cd);
>  +      mutt_decode_quoted (s, b->length, istext || ((WithCrypto & 
> APPLICATION_PGP) && mutt_is_application_pgp (b)), cd);

  This indeed (which made CVS) fixed the problem back in the day. Glad
  that the bug was not closed, though, since I've received another bug
  report showing this problem (bugs.debian.org/344704).

  I've nailed it down to the combination of those base64 messages _with_
  a multipart/alternative. A sample message that fails to open with
  latest Mutt CVS can be found here:

    http://people.debian.org/~adeodato/tmp/2006-03-03/base64+multipart.mbox
    
  (It's the same message as [1], but wrapped in multipart/alternative.)

    [1] http://people.debian.org/~adeodato/tmp/2005-11-21/base64.mbox

  This one time, though, non-crlf base64 does not help.

  Thanks in advance,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
                              Listening to: Pedro Guerra - Siete puertas