<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] expand mutt vars as we do environment vars



On 2006-01-11 at 22:13 -0800, Brendan Cully wrote:
> Seeing that cool group patch Thomas just posted, I thought it might be
> a good time to sneak in this feature patch too. I haven't received any
> negative feedback so far - now that it's in CVS, it may be a
> different story ;)

Sorry.  :^)

Infinite loop bug if you attempt to delete an unset variable.

--- mutt/init.c 2006-01-12 13:26:41.000000000 +0100
+++ mutt-workingcopy/init.c     2006-01-12 13:53:43.000000000 +0100
@@ -3050,7 +3050,7 @@
   myvar_t* cur;
   myvar_t* prev;
 
-  for (prev = cur = MyVars; cur; prev = cur, cur = cur->next)
+  for (prev = cur = MyVars; cur && cur->next != cur; prev = cur, cur = 
cur->next)
   {
     if (!mutt_strcmp (cur->name, var))
     {