<<< Date Index >>>     <<< Thread Index >>>

[PATCH] Re: mutt IMAP seg-fault in imap/browse.c



On 2006-01-04 at 12:28 +0100, Phil Pennock wrote:
> I can now reproduce this.

Solved; unitialised stack-allocated structure.

With patch below, I can no longer replicated this segfault.

diff -ur mutt/imap/browse.c mutt-workingcopy/imap/browse.c
--- mutt/imap/browse.c  2005-12-21 23:10:01.000000000 +0100
+++ mutt-workingcopy/imap/browse.c      2006-01-04 15:07:11.000000000 +0100
@@ -45,7 +45,7 @@
 int imap_browse (char* path, struct browser_state* state)
 {
   IMAP_DATA* idata;
-  IMAP_LIST list;
+  IMAP_LIST list = {0};
   char buf[LONG_STRING];
   char buf2[LONG_STRING];
   char nsbuf[LONG_STRING];

-- 
I am keeping international relations on a peaceable footing.
You are biding your time before acting.
He is coddling tyrants.
 -- Roger BW on topic of verb conjugation