Re: mutt/2144: Please always use ascii_strcasecmp to compare ASCII parameter strings
The following reply was made to PR mutt/2144; it has been noted by GNATS.
From: Brendan Cully <brendan@xxxxxxxxxx>
To: bug-any@xxxxxxxxxxxxx
Cc:
Subject: Re: mutt/2144: Please always use ascii_strcasecmp to compare ASCII
parameter strings
Date: Fri, 16 Dec 2005 10:37:59 -0800
On Friday, 16 December 2005 at 15:45, Recai Oktas wrote:
> The following reply was made to PR mutt/2144; it has been noted by GNATS.
>
> From: Recai Oktas <roktas@xxxxxxxxxx>
> To: bug-any@xxxxxxxxxxxxx
> Cc:
> Subject: Re: mutt/2144: Please always use ascii_strcasecmp to compare ASCII
> parameter strings
> Date: Fri, 16 Dec 2005 16:37:01 +0200
> * Brendan Cully [2005-12-13 20:18:49+0100]
> > Synopsis: Please always use ascii_strcasecmp to compare ASCII parameter s=
> trings
> >=20
> > **** Comment added by brendan on Tue, 13 Dec 2005 20:18:49 +0100 ****
> > I'd like to see this patch with mutt_ascii_* changed back to ascii_*. I
> > know it may seem a little inconsistent, but this patch doesn't make
> > things better in that regard, since all the other callers are still
> > using the old name. If you use the ascii_* form, this patch looks fine
> > to me.
>
> Sorry for the late response. I've successfully tested the patch attached.
> It seems to work without any observed problem.
>
> Regards,
>
> roktas
>
> Content-Type: text/x-patch; charset=iso-8859-9
> Content-Disposition: attachment; filename="mutt_ascii_strcase.patch"
> Content-Transfer-Encoding: quoted-printable
Ok. Now I just have to figure out how to degnatsify the patch. Might
be time to start looking at alternative BTSes again :)