Re: mutt/2144: Please always use ascii_strcasecmp to compare ASCII parameter strings
The following reply was made to PR mutt/2144; it has been noted by GNATS.
From: Recai Oktas <roktas@xxxxxxxxxx>
To: bug-any@xxxxxxxxxxxxx
Cc:
Subject: Re: mutt/2144: Please always use ascii_strcasecmp to compare ASCII
parameter strings
Date: Fri, 2 Dec 2005 00:11:03 +0200
--M9NhX3UHpAaciwkO
Content-Type: text/plain; charset=iso-8859-9
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi,
> Is there any particular reason why you introduce additional
> functions with a mutt_prefix, instead of using ascii_strcasecmp
> and ascii_strncasecmp?
>=20
> (I haven't looked at the patch, just at the description.)
Well, for the same reasons of using those 'mutt' prefixed wrappers. I
didn't want any side effects introduced by this patch. Besides this, I
thought that, a new wrapper set for ascii comparisons might have been
more instructive to suggest the proper usage in similar cases.
I've just tested the patch and it has worked (i.e. no more parse error
on startup). The decision of whether to accept the new functions is
yours, it shouldn't effect the result.
Regards,
--=20
roktas
--M9NhX3UHpAaciwkO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFDj3T3nA44mz/SXIQRAgozAJwN7F8Jo4Ynq9YgBKe8eyI05htC9QCfXqz1
CxPYYc1kOm3uYc7CUK7vSTk=
=1Ram
-----END PGP SIGNATURE-----
--M9NhX3UHpAaciwkO--