Re: SMTP $envelope_from
On Thursday, 08 September 2005 at 09:51, Brendan Cully wrote:
> On Thursday, 08 September 2005 at 16:59, Alain Bench wrote:
> > Hi Brendan,
> >
> > On Wednesday, September 7, 2005 at 8:02:36 AM -0700, Brendan Cully wrote:
> >
> > > to make $envelope_from an address (possibly renaming the current
> > > $envelope_from to $use_envelope_from).
> >
> > My humble:
> >
> > · Renaming vars should be avoided, unless tremendous benefit.
>
> I don't like it either. I just couldn't think of good variable names
> that wouldn't cause confusion. Maybe symlink envelope_from to
> use_envelope_from and add envelope_from_address?
I've just committed a patch that does this. $envelope_from_address is
only used when $use_envelope_from is set (cf. $from, $use_from). For
the SMTP case, we'll just behave as if $use_envelope_from is always
set, since there is no sendmail default.