Re: [PATCH] ME's SMTP relay patch ported to CVS

[Brendan Cully <brendan@xxxxxxxxxx>]

On Wednesday, 07 September 2005 at 08:34, Claus Assmann wrote:
> On Wed, Sep 07, 2005, Brendan Cully wrote:
> 
> Just a brief comment about a "common" RFC violation:
> 
> > +      snprintf (buf, sizeof (buf), "RCPT TO: <%s> NOTIFY=%s\r\n",
> 
> > +      snprintf (buf, sizeof (buf), "RCPT TO: <%s>\r\n", a->mailbox);
> 
> > +    ret = snprintf (buf, sizeof (buf), "MAIL FROM: <%s>", from->mailbox);
> 
> 
> Please see RFC 2821. There is no space between ':' and '<',
> it must look like this:
> 
> > +      snprintf (buf, sizeof (buf), "RCPT TO:<%s> NOTIFY=%s\r\n",
> > +      snprintf (buf, sizeof (buf), "RCPT TO:<%s>\r\n", a->mailbox);
> > +    ret = snprintf (buf, sizeof (buf), "MAIL FROM:<%s>", from->mailbox);

Thanks, I've fixed this in my tree. Now, do you suppose there are any
servers out there that make the same mistake (ie expect a space after
the colon when parsing)? Because no one seems to mind if the client
does it...

Attachment: pgpUsPxMyyJmu.pgp
Description: PGP signature