Re: [PATCH] ME's SMTP relay patch ported to CVS
On Wed, Sep 07, 2005, Brendan Cully wrote:
Just a brief comment about a "common" RFC violation:
> + snprintf (buf, sizeof (buf), "RCPT TO: <%s> NOTIFY=%s\r\n",
> + snprintf (buf, sizeof (buf), "RCPT TO: <%s>\r\n", a->mailbox);
> + ret = snprintf (buf, sizeof (buf), "MAIL FROM: <%s>", from->mailbox);
Please see RFC 2821. There is no space between ':' and '<',
it must look like this:
> + snprintf (buf, sizeof (buf), "RCPT TO:<%s> NOTIFY=%s\r\n",
> + snprintf (buf, sizeof (buf), "RCPT TO:<%s>\r\n", a->mailbox);
> + ret = snprintf (buf, sizeof (buf), "MAIL FROM:<%s>", from->mailbox);