<<< Date Index >>>     <<< Thread Index >>>

[PATCH] memleak in mutt_menuDestroy



Hello,
while valgrinding the header cache I found another memleak in mutt. This
one was triggered from:

==1895== 76 bytes in 1 blocks are definitely lost in loss record 17 of 71
==1895==    at 0x1B905861: calloc (vg_replace_malloc.c:176)
==1895==    by 0x80A5EBE: safe_calloc (lib.c:65)
==1895==    by 0x80B8A64: ssl_check_certificate (mutt_ssl.c:574)
==1895==    by 0x80B82FF: ssl_negotiate (mutt_ssl.c:338)
==1895==    by 0x80B8205: ssl_socket_open (mutt_ssl.c:285)
==1895==    by 0x80B6FF2: mutt_socket_open (mutt_socket.c:55)
==1895==    by 0x80BD576: imap_open_connection (imap.c:392)
==1895==    by 0x80BD4D7: imap_conn_find (imap.c:367)
==1895==    by 0x80BD8F3: imap_open_mailbox (imap.c:538)
==1895==    by 0x8081FE8: mx_open_mailbox (mx.c:694)

Politely,
        Thomas [ who has now a xpolitely in his .vimrc ]
diff -Nru a/menu.c b/menu.c
--- a/menu.c    2004-08-10 11:59:52 +02:00
+++ b/menu.c    2004-08-10 11:59:52 +02:00
@@ -692,7 +692,7 @@
     for (i=0; i < (*p)->max; i++)
       FREE (&(*p)->dialog[i]);
 
-    FREE ((*p)->dialog);
+    FREE (& (*p)->dialog);
   }
 
   FREE (p);