Re: [PATCH] generic spam detection
Hi Thomas,
On Wed, Jul 14, 2004 at 09:00:50AM +0200, Thomas Glanzmann wrote:
> * TAKAHASHI Tamotsu <ttakah@xxxxxxxxxxxxxxxxx> [040714 07:40]:
> > Okay, I wrote a bogus patch against hcache19. (attached.)
> > (Of cource, sizeof(int) should be too short for spam/nospam IDs.
> > Moreover, I'm not sure whether it works as expected. :)
>
> tell me what you want and I am going to include it in the 'header
You will need this feature _after_ spam detection is commmited to CVS.
I want your patch to dump/restore e->spam, SpamList and NoSpamList,
and to check whether SpamList or NoSpamList has been changed before
restoring e->spam. If changed, stop restoring. (similar to charset)
> cache'. Btw. a friend of mine, Tobias Werth, who is an frequently IMAP
> user, visited me on Sunday and we extended the previous Maildir header
> cache to support IMAP as well. I am going to release the patch shortly
> to the public.
Wow, I'm glad to hear that!
By the way, version 18 (the same as 19) is exceedingly stable. What about
asking TLR for CVS inclusion again? You have your httpd log to show how
many times your patch has been downloaded? We all have been testing the
patch for long enough time. And yes, your patch is safe. It does not change
anything when mutt is configured without --enable-hcache. Users want
header-caching more than GPGME-S/MIME, IMHO.
--
tamo