Re: [PATCH] $sort_browser does'n t take "subject" order. Documentation is wrong.
On Mon, Jul 12, 2004 at 07:50:24PM +0900, TAKAHASHI Tamotsu wrote:
> manual.sgml says that the default value of the $sort_browser
> variable is "subject", but that's wrong. It should be "alpha."
> It is in fact SORT_SUBJECT, but translated to "alpha" internally.
>
> I wrote a patch to hack makedoc.c. This is not smart at all.
> But the problem itself is a design flaw IMHO. Gave up.
I've found a better solution. Attached.
You can easily confirm that this change is safe.
--
tamo
--- sort.h~ Wed Nov 7 05:38:17 2001
+++ sort.h Tue Jul 13 09:11:36 2004
@@ -19,6 +19,7 @@
#define SORT_DATE 1 /* the date the mail was sent. */
#define SORT_SIZE 2
#define SORT_SUBJECT 3
+#define SORT_ALPHA 3 /* makedoc.c requires this */
#define SORT_FROM 4
#define SORT_ORDER 5 /* the order the messages appear in the mailbox. */
#define SORT_THREADS 6
--- init.h~ Sat Jul 10 17:53:24 2004
+++ init.h Tue Jul 13 09:10:21 2004
@@ -2081,7 +2081,7 @@
** order $$sort_aux is reversed again (which is not the right thing to do,
** but kept to not break any existing configuration setting).
*/
- { "sort_browser", DT_SORT|DT_SORT_BROWSER, R_NONE, UL &BrowserSort,
SORT_SUBJECT },
+ { "sort_browser", DT_SORT|DT_SORT_BROWSER, R_NONE, UL &BrowserSort,
SORT_ALPHA },
/*
** .pp
** Specifies how to sort entries in the file browser. By default, the