Re: [PATCH] Squelch compiler warnings

[Vincent Lefevre <vincent@xxxxxxxxxx>]

On 2010-11-04 18:41:55 +0530, Ramkumar Ramachandra wrote:
> * Replace several 'mktemp' with safer 'mkstemp' alternative.

But there is a difference in case of error. According to the man pages,

* for mktemp:

    If a unique name could not be created, template is made an empty
    string.

* for mkstemp:

    On success, these functions return the file descriptor of the
    temporary file. On error, -1 is returned, and errno is set
    appropriately.

So, Mutt should be modified accordingly to take errors into account.

-- 
Vincent Lefèvre <vincent@xxxxxxxxxx> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon)