<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH 7 of 9] Fix comparison signedness warning



On Sat, Aug 07, 2010 at 10:04:01AM +0200, Matthias Andree wrote:
Because of the deduction, I cast without adding a check, but you have a valid point. Note there is a "if (chunk < 0)" check above.

...

So what do we do? Drop this patch? Keep it? Add a comment before line 501? Add an assertion before line 501?

Adding a comment about the precondition for the cast being safe might be wise.

me

Attachment: pgpsXsgXMzPFw.pgp
Description: PGP signature