<<< Date Index >>>     <<< Thread Index >>>

Re: [Mutt] #3298: Mutt's way to get the FQDN is broken



#3298: Mutt's way to get the FQDN is broken
---------------------+------------------------------------------------------
  Reporter:  vinc17  |       Owner:  mutt-dev
      Type:  defect  |      Status:  new     
  Priority:  major   |   Milestone:          
 Component:  mutt    |     Version:  1.5.20  
Resolution:          |    Keywords:          
---------------------+------------------------------------------------------

Comment(by Rocco Rutte):

 {{{
 Hi,

 * Mutt wrote:


 The prototypes should go into protos.h, there examples for all other
 compat routines we ship. But in this case it may not be a good idea if
 we define structs there, too. (An idea could be compat.h for all protos
 plus other definitions)

 I think the correct solution is to have one replacement source file per
 backwards compatibility function. Because if you miss function A but
 have B and and define A and B in the same file, you may get B twice.

 So I'd say we want two new files, and two tests in configure.ac just
 like you did already.

 If the code is used in one place only, you could also just embed the
 code surrounded by #ifdef/#endif with macros defined by configure in
 config.h.

 Rocco
 }}}

-- 
Ticket URL: <http://dev.mutt.org/trac/ticket/3298#comment:>
Mutt <http://www.mutt.org/>
The Mutt mail user agent