<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH 0 of 2] minor build and INSTALL fixes

Am 07.07.2009, 15:48 Uhr, schrieb Matthias Andree <matthias.andree@xxxxxx>:


Rocco Rutte schrieb:

Hi,

* Matthias Andree wrote:

* Matthias Andree wrote:



Patch 1 removes a file from the repo that is installed by autoreconf
as part of prepare.



Not for me. Neither on OS X nor on Debian squeeze. On OSX I have
autoconf 2.63 and automake 1.10.2, and on Debian 2.63/1.9.6.



then you're lucky: Your automake version is new enough so that it
uses "install-sh -d" instead, and mkinstalldirs is no longer needed
(install-sh is also installed by automake).



I've emailed a rebased version of this PATCH to this list.


I see. But then it's not enough, "mkinstalldirs" is used in:

$ grep mkinstalldirs `find . -name Makefile.am`
./contrib/Makefile.am: $(top_srcdir)/mkinstalldirs $(DESTDIR)$(docdir)/samples $(DESTDIR)$(docdir)/samples/iconv ./doc/Makefile.am: $(top_srcdir)/mkinstalldirs $(DESTDIR)$(mandir)/man1 ./doc/Makefile.am: $(top_srcdir)/mkinstalldirs $(DESTDIR)$(mandir)/man5 ./doc/Makefile.am: $(top_srcdir)/mkinstalldirs $(DESTDIR)$(sysconfdir) 
./doc/Makefile.am:      $(top_srcdir)/mkinstalldirs $(DESTDIR)$(docdir)
./Makefile.am:  $(srcdir)/mkinstalldirs $(DESTDIR)$(sysconfdir)

These should be fixed, too, I guess, as well as removing some
dependencies on mkinstalldirs.


Indeed they should. I'll look into this tonight.
Please disregard this patch and my rebased followup patch.
I think the mutt gettext hacks have been part of the problem. What were they for anyways? They seem to be for a way obsolete gettext version. Shouldn't we just update to gettext 0.17 and be done? I'm not going to do that for this patch round, but just amend to the hacks, but in the long run, we should split our stuff to a m4-mutt directory and let gettext deal with the rest. 

Does any of the core maintainers NOT having GNU gettext 0.17 installed?

--
Matthias Andree