Re: [PATCH 2 of 4] Fix various resource leaks throughout sendlib.c
>> >> - CONTEXT f;
>> >> + CONTEXT *f = NULL;
>> >
>> > Here I don't understand what the leak should be. It just changes from
>> > stack to allocated memory causing more overhead I think. Can you explain
>> > why you change this?
>
>> Heh, the problem here is that the function that clears CONTEXT f
>> returns a pointer as an error indicator.
>
> [...]
>
> I see. mx_open_mailbox() allocates memory if you pass a null
> pointer. Shouldn't that also be released somewhere?
It should be released when necessary. If not, it may be in another patchset
accidentally. I will look.
E
--
Erik Hovland
erik@xxxxxxxxxxx
http://hovland.org/