Re: [PATCH 16 of 16] free intermediates in error path

[Rocco Rutte <pdmef@xxxxxxx>]

Hi,

* Erik Hovland wrote:

> Static analyzers do shine. But only when humans use them right. Here
> is the corrected patch for the same thing after fixing my usage of the
> tool.

Sorry for being so tenacious on this issue.

I'm still not convinced this is right. The first free is okay. But in
case of no error and intermediates == NULL, it's set to SmimeDefaultKey
which is a config value. If you later free that, you free the config
value.

So I think that all subsequent FREE calls should actually be made only
if intermediates != SmimeDefaultKey perhaps with a label and goto.

Rocco