<<< Date Index >>>     <<< Thread Index >>>

[PATCH 03 of 16] Since contex_sb might be uninitialized, it is

1 file changed, 3 insertions(+), 6 deletions(-)
buffy.c |    9 +++------


# HG changeset patch
# User Erik Hovland <erik@xxxxxxxxxxx>
# Date 1236890095 25200
# Branch HEAD
# Node ID b4cf86788470dceb7bc4f80edc7f9b7098839a43
# Parent  abb26dfac5656d678607e215f36a1c52db460a19
Since contex_sb might be uninitialized, it is
better to zero it and remove the condition
that does that.

diff --git a/buffy.c b/buffy.c
--- a/buffy.c
+++ b/buffy.c
@@ -260,6 +260,9 @@
   struct stat contex_sb;
   time_t t;
 
+  contex_sb.st_dev=0;
+  contex_sb.st_ino=0;
+
 #ifdef USE_IMAP
   /* update postponed count as well, on force */
   if (force)
@@ -285,12 +288,6 @@
 #ifdef USE_POP
   if (!Context || Context->magic != M_POP)
 #endif
-  /* check device ID and serial number instead of comparing paths */
-  if (!Context || !Context->path || stat (Context->path, &contex_sb) != 0)
-  {
-    contex_sb.st_dev=0;
-    contex_sb.st_ino=0;
-  }
   
   for (tmp = Incoming; tmp; tmp = tmp->next)
   {